Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-1893. Fix bug in removeAcl in Bucket. #1216

Merged
merged 1 commit into from
Aug 5, 2019
Merged

HDDS-1893. Fix bug in removeAcl in Bucket. #1216

merged 1 commit into from
Aug 5, 2019

Conversation

bharatviswa504
Copy link
Contributor

No description provided.

@bharatviswa504 bharatviswa504 self-assigned this Aug 2, 2019
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 49 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
0 mvndep 18 Maven dependency ordering for branch
+1 mvninstall 586 trunk passed
+1 compile 371 trunk passed
+1 checkstyle 74 trunk passed
+1 mvnsite 0 trunk passed
+1 shadedclient 832 branch has no errors when building and testing our client artifacts.
+1 javadoc 167 trunk passed
0 spotbugs 418 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 606 trunk passed
_ Patch Compile Tests _
0 mvndep 25 Maven dependency ordering for patch
+1 mvninstall 555 the patch passed
+1 compile 381 the patch passed
+1 javac 381 the patch passed
+1 checkstyle 84 the patch passed
+1 mvnsite 0 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 662 patch has no errors when building and testing our client artifacts.
+1 javadoc 167 the patch passed
+1 findbugs 632 the patch passed
_ Other Tests _
+1 unit 305 hadoop-hdds in the patch passed.
-1 unit 1698 hadoop-ozone in the patch failed.
+1 asflicense 35 The patch does not generate ASF License warnings.
7428
Reason Tests
Failed junit tests hadoop.ozone.client.rpc.TestCommitWatcher
hadoop.hdds.scm.pipeline.TestPipelineClose
hadoop.ozone.client.rpc.TestOzoneAtRestEncryption
hadoop.ozone.client.rpc.TestOzoneRpcClient
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient
hadoop.ozone.om.TestScmSafeMode
hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/artifact/out/Dockerfile
GITHUB PR #1216
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 14cc1a017ec2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / b964b81
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/testReport/
Max. process+thread count 4524 (vs. ulimit of 5500)
modules C: hadoop-ozone/ozone-manager hadoop-ozone/integration-test U: hadoop-ozone
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1216/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

xiaoyuyao
xiaoyuyao approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@xiaoyuyao xiaoyuyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1. I will commit it shortly.

@xiaoyuyao xiaoyuyao merged commit c589983 into apache:trunk Aug 5, 2019
asfgit pushed a commit that referenced this pull request Aug 5, 2019
@bharatviswa504 @xiaoyuyao
HDDS-1893. Fix bug in removeAcl in Bucket. (#1216)
cffa42b 
(cherry picked from commit c589983)
amahussein pushed a commit to amahussein/hadoop that referenced this pull request Oct 29, 2019
@bharatviswa504
HDDS-1893. Fix bug in removeAcl in Bucket. (apache#1216)
7ed3c04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyuyao xiaoyuyao xiaoyuyao approved these changes

@arp7 arp7 Awaiting requested review from arp7

Assignees

@bharatviswa504 bharatviswa504

Labels
ozone
Projects
None yet
Milestone
No milestone
3 participants
@bharatviswa504 @hadoop-yetus @xiaoyuyao